Add ability to invoke CoinbaseAccount with a known good oauth access token #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…token. Support basestring type for api_key and access_token arguments.
|
Can you pull the latest version of the library and make this function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements setting an arbitrary access_token for use when an oauth implementation whose data structures are not compatible with what the oauth2_credentials parameter expects.
In my testing I also ran into a situation when I was working with a string that was cast to unicode that produced an error when doing the 'type() is str' test. I modified the two instances of this (one in my new code and one in existing code) to check if the variables were instances of basestring instead.