Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compat with new ts@4.7's node16 resolution #5

Merged
merged 1 commit into from
May 28, 2022
Merged

fix: compat with new ts@4.7's node16 resolution #5

merged 1 commit into from
May 28, 2022

Conversation

AviVahl
Copy link
Contributor

@AviVahl AviVahl commented May 26, 2022

new typescript version picks up the "types" key instead of the root "typings" when in "node16" resolution mode.
also defined both "require" and "import" bundles so they can be natively required/imported in each mode.

new typescript version picks up the "types" key instead of the root "typings" when in "node16" resolution mode.
also defined both "require" and "import" bundles so they can be natively required/imported in each mode.
Copy link
Owner

@sibiraj-s sibiraj-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AviVahl

@sibiraj-s sibiraj-s enabled auto-merge (squash) May 28, 2022 02:38
@sibiraj-s sibiraj-s merged commit e8937d8 into sibiraj-s:master May 28, 2022
@sibiraj-s
Copy link
Owner

Published in v1.1.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants