Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is just a suggestion to migrate to standalone components etc #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

This is just a suggestion to migrate to standalone components etc #70

wants to merge 4 commits into from

Conversation

Julian-B90
Copy link

@Julian-B90 Julian-B90 commented Jul 2, 2024 •
edited
Loading

  • Migrate Lib to Standalone API
  • Update Cypress 13.13.0

@sibiraj-s
Copy link
Owner

Thanks, Will look into it. I would have preferred a discussion prior to making breaking changes.

@Julian-B90
Copy link
Author

Maybe with that 2eb86c0 we can offer both?

@sibiraj-s
Copy link
Owner

Maybe with that 2eb86c0 we can offer both?

I am not sure at this point if there would be any size increase if both are provided, since I never tried it.

Also, its fine to make breaking changes for a better API or make it more easy to use. I just said I wish there could have been a discussion nothing else.

sibiraj-s
sibiraj-s requested changes Jul 19, 2024
View reviewed changes
Copy link
Owner

@sibiraj-s sibiraj-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ❤️

Changes looks good to me, can you delete the module file? I will test these changes a bit and release them.

projects/ngx-tiptap/src/lib/ngx-tiptap.module.ts Outdated Show resolved Hide resolved
projects/ngx-tiptap/src/public-api.ts Outdated Show resolved Hide resolved
@sibiraj-s sibiraj-s mentioned this pull request Sep 17, 2024
Open
@sibiraj-s
Copy link
Owner

Sorry for the delay, If you could resolve the conflicts, I can get it merged and released as next major.

@Julian-B90
Copy link
Author

@sibiraj-s i have resolve the merge conflicts

@Julian-B90
Copy link
Author

@sibiraj-s ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sibiraj-s sibiraj-s Awaiting requested review from sibiraj-s

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Julian-B90 @sibiraj-s