Replace uses of celery.utils.time #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkseppan
changed the title
|
Looks like requirements-dev.txt needs an update for backports.timezone for 3.8. |
|
fixes #219 |
The FixedOffset and timezone imports were actually from pytz, which has been deprecated and therefore removed as a celery dependency. Instead, use zoneinfo in Python 3.9+ and backports.zoneinfo in earlier Python 3 versions to look up timezones by name, and use dateutil.timezone.utc and dateutil.timezone(timedelta(...)) to construct timezones that are a fixed offset from UTC. For background and inspiration, see pganssle/pytz-deprecation-shim, but that is not necessary as a dependency for these uses. Fixes sibson#244.
|
I pushed a new version that adds the requirement to requirements-dev.txt and fixes the import order flagged by the linter. |
miketheman
added a commit
to miketheman/redbeat
that referenced
this pull request
Jun 12, 2023
Was implicitly being installed via Celery, which was removed in 5.3.0 celery/celery#8159 Related to sibson#245 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FixedOffset and timezone imports were actually from pytz, which has been deprecated and therefore removed as a celery dependency. Instead, use zoneinfo in Python 3.9+ and backports.zoneinfo in earlier Python 3 versions to look up timezones by name, and use dateutil.timezone.utc and dateutil.timezone(timedelta(...)) to construct timezones that are a fixed offset from UTC.
For background and inspiration, see pganssle/pytz-deprecation-shim, but that is not necessary as a dependency for these uses.
Fixes #244.
This passes tests for me but I haven't run extensive experiments yet.