Edit record not possible

[rjahn]

Screen: Contacts (DB)

Press the pencil beside the table:

The response contains the comman property (startEditing):

        "changedComponents": [
            {
                "id": "T624",
                "startEditing": true
            }
        ],

which should switch the table in edit mode for the current selected record/column.

fyi: A command property is a dynamic property only, for only one response.

[gimmixAT]

this should work correctly again

[rjahn]

Edit action is working

BUT:

• cell-height is growing 1px
• In Lazy-Loading screen: edit and Escape (cancel) lets ACTIVE cell flickr

[gimmixAT]

The cell / row height issue should be fixed.
I can't repdroduce the flicker in FF or Chrome on WIndows. I guess you are seeing this on macOS @rjahn ?

[rjahn]

Flickr is with macOS and Chrome, but only if developer tools are embedded and only if you press the pencil - not if you double click with mouse.

[gimmixAT]

@rjahn could you please attach a short screencap, I am not able to reproduce any flicker in chrome on macOS

[rjahn]

Sure:

flickering.mp4

The difference is that button click sends a request and in case of developer console, all images are requested again?

I saw that images are requested for change row selection? Why?

Without developer tools, the column doesn't flickr.

[gimmixAT]

In your case the caching is disabled in the developer mode. So if an image (the checkbox) is rerendered the image isn't fetched from the cache and reloaded hence the flicker.

[rjahn]

You're right!

The only open question here: Why does caching work in case of double-click a cell and pressing Esc vs. Pencil and Esc?

[gimmixAT]

doubleclicking it only starts the editing session on the client apparently since there seems to be no request sent at that moment. So just the cell rerenders to display the editor.

When clicking the pen, the editing session is triggered by the server response, which in turn causes a rerender of the table content

[rjahn]

From my point of view, there should be no difference if user double clicks or gets the response which will start editing?
At the end, the editor starts editing? Do we have two different edit modes?

Are we safe here?

[gimmixAT]

The end result is basically the same so we should be safe on that end. Just how react propagates those changes of the editing mode is different and causes some rendering side effects (like unnecessary DOM updates) on the way.
This should be remediable once we retool the react stack a bit and optimize more for recycling components.