Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set visible only the details page #167

Merged
1 commit merged into from
Sep 9, 2020
Merged

Fix: set visible only the details page #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions client/src/components/Dashboard/Dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import { Switch, Route } from 'react-router-dom';
// import Score from '../Score/Score';
import Details from '../Details/Details';
import './Dashboard.scss';
import Sandbox from '../Sandbox/Sandbox';
// import Sandbox from '../Sandbox/Sandbox';
import NotFound from '../common/NotFound';
import Model from '../Model/Model';
import FeatureImportance from '../Model/FeatureImportance';
import FeatureDistrubution from '../Model/FeatureDistrubution';
// import FeatureImportance from '../Model/FeatureImportance';
// import FeatureDistrubution from '../Model/FeatureDistrubution';

const Dashboard = (props) => {
const { location } = props;
Expand All @@ -16,10 +16,10 @@ const Dashboard = (props) => {
<div className="dashboard">
<Switch location={location}>
<Route path="/entity/:id" component={Details} />
<Route path="/sandbox" exact component={Sandbox} />
{/* <Route path="/sandbox" exact component={Sandbox} /> */}
<Route path="/model" component={Model} />
<Route path="/global-feature-importance" component={FeatureImportance} />
<Route path="/feature-distribution" component={FeatureDistrubution} />
{/* <Route path="/global-feature-importance" component={FeatureImportance} /> */}
{/* <Route path="/feature-distribution" component={FeatureDistrubution} /> */}
{/* <Route path="/" exact component={Score} /> */}
<Route path="*" component={NotFound} />
</Switch>
Expand Down
29 changes: 29 additions & 0 deletions client/src/components/Details/Details.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,32 @@
.dash-controls {
display: flex;

li {
flex: 1 1;
margin-right: 10px;

&.sep {
flex: 0;
border-right: 1px solid #e0e0e0;
}

&:last-child {
margin-right: 0;
}

&.results-counter {
font-size: 14px;
line-height: 40px;
flex: 0 1;
white-space: nowrap;
margin-right: 10px;
span {
font-weight: bold;
}
}
}
}

.sub-header {
h4 {
margin: 10px 0;
Expand Down
10 changes: 5 additions & 5 deletions client/src/components/Sidebar/Sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
IndicatorIcon,
// ScoreIcon,
DetailsIcon,
SandboxIcon,
// SandboxIcon,
// SimilarChildrenIcon,
ModelIcon,
MetLogo,
Expand Down Expand Up @@ -45,12 +45,12 @@ class Sidebar extends Component {
<span>Details</span>
</NavLink>
</li>
<li>
{/* <li>
<NavLink exact to="/sandbox" onClick={() => setActivePage('Sandbox')}>
<SandboxIcon />
<span>Sandbox</span>
</NavLink>
</li>
</li> */}
{/*
Temporarily 'disabled'
<li>
Expand All @@ -65,7 +65,7 @@ class Sidebar extends Component {
<span>About Model</span>
<IndicatorIcon dir="right" />
</button>
<ul>
{/* <ul>
<li>
<NavLink
exact
Expand All @@ -80,7 +80,7 @@ class Sidebar extends Component {
<span>Feature Distribution</span>
</NavLink>
</li>
</ul>
</ul> */}
</li>
</ul>
</div>
Expand Down