Fix schema path globbing on Windows #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboure
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
LGTM! Thank for a new contrib!
Would you mind fixing this in https://github.com/bboure/serverless-appsync-simulator too?
|
Seems very similar at first glance, so I should be able to do it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404
The issue is caused by
globbynot working with windows paths as patterns. More preciselyfast-globwhich is whatglobbyis based on does not support windows paths as patterns and it seems to be intentional, so I don't think it will change anytime soon.fast-globrecommends replacing\\with/so I did that and it worked.