Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minSize option #209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add minSize option #209

wants to merge 1 commit into from

Conversation

larionov
Copy link

@larionov larionov commented Apr 4, 2018

Adds minSize, --min-size option to fail if size of the bundle is too small.

Description

Motivation and Context

Fixes #207.
Sometimes it's useful to also have a warning when your bundle suddenly becomes too small, maybe that wasn't intentional.
This crosses a bit into the functional tests realm but this check I think is simple enough and could serve as a sanity check for some hard-to-test changes, like in css bundles, which require visual/screenshot testing that is not always done.

Even if functional tests for your build are implemented I think the name bundlesize and maxSize options do imply that this tool made for the checking all the things about allowed sizes of files, so it makes sense to keep the information about minimal allowed sizes in the same config.

Screenshots (if appropriate):

screenshot_2018-04-04_12-44-47

Types of changes

  • New feature (non-breaking change which adds functionality)

@safonoi
Copy link

safonoi commented Apr 5, 2019

It's very use useful for controlling the minimum chunk size. Please review PR. We are waiting for this feature.

@SmolinPavel
Copy link

This is the feature we are waiting for!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minSize option
3 participants