Refactor code to support Siddhi 5.0.0 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhothayan
reviewed
Jun 19, 2019
| @@ -0,0 +1,6 @@ | |||
| threadfix is used in Python 3.4+ to treat a threading related bug introduced in Python 3.4. | |||
There was a problem hiding this comment.
Since this is a markdown file, do we still need to add the license header?
suhothayan
reviewed
Jun 19, 2019
| @@ -1,6 +1,6 @@ | |||
| # Siddhi App Management using PySiddhi Client | |||
|
|
|||
| Using _WSO2 SP Client_ in _PySiddhi4_, following operations can be undertaken on _Siddhi App Management_ of _WSO2 SP 4.0_. | |||
| Using _WSO2 SP Client_ in _PySiddhi_, following operations can be undertaken on _Siddhi App Management_ of _WSO2 SP 4.0_. | |||
suhothayan
approved these changes
Jun 19, 2019
grainier
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR refactor code to support Siddhi 5.0.0. Addition to that it removes the version numbers from component names.
Security checks