Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give support for concat function to accept other data types( integer, double, long, float) #73

Closed
wants to merge 1 commit into from
Closed

Give support for concat function to accept other data types( integer, double, long, float) #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion component/src/main/java/io/siddhi/extension/execution/string/ConcatFunctionExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
parameters = {
@Parameter(name = "arg",
description = "This can have two or more `string` type input parameters.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description need to reflect the new change

type = {DataType.STRING},
type = {DataType.STRING, DataType.INT, DataType.DOUBLE, DataType.FLOAT, DataType.LONG},
dynamic = true)
},
parameterOverloads = {
Expand Down
84 changes: 84 additions & 0 deletions ...t/src/test/java/io/siddhi/extension/execution/string/ConcatFunctionExtensionTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,90 @@ public void receive(long timeStamp, Event[] inEvents, Event[] removeEvents) {
siddhiAppRuntime.shutdown();
}

@Test
public void testConcatWithIntegers() throws InterruptedException {
LOGGER.info("ConcatFunctionExtension TestCase");
SiddhiManager siddhiManager = new SiddhiManager();

String inStreamDefinition = "define stream inputStream (symbol1 string, symbol2 int, symbol3 string);";
String query = ("@info(name = 'query1') from inputStream select symbol1 , " +
"str:concat(symbol1,symbol2,symbol3) as concatString " +
"insert into outputStream;");
SiddhiAppRuntime siddhiAppRuntime = siddhiManager.createSiddhiAppRuntime(inStreamDefinition + query);

siddhiAppRuntime.addCallback("query1", new QueryCallback() {
@Override
public void receive(long timeStamp, Event[] inEvents, Event[] removeEvents) {
EventPrinter.print(timeStamp, inEvents, removeEvents);
for (Event event : inEvents) {
count.incrementAndGet();
if (count.get() == 1) {
AssertJUnit.assertEquals("AAACCC", event.getData(1));
eventArrived = true;
}
if (count.get() == 2) {
AssertJUnit.assertEquals("123123789", event.getData(1));
eventArrived = true;
}
if (count.get() == 3) {
AssertJUnit.assertEquals("D533456XYZ", event.getData(1));
eventArrived = true;
}
}
}
});

InputHandler inputHandler = siddhiAppRuntime.getInputHandler("inputStream");
siddhiAppRuntime.start();
inputHandler.send(new Object[]{"AAA", null, "CCC"});
inputHandler.send(new Object[]{"123", 123, "789"});
inputHandler.send(new Object[]{"D533", 456, "XYZ"});
SiddhiTestHelper.waitForEvents(100, 3, count, 60000);
AssertJUnit.assertEquals(3, count.get());
AssertJUnit.assertTrue(eventArrived);
siddhiAppRuntime.shutdown();
}

@Test
public void testConcatWithIntDoubleLongFloat() throws InterruptedException {
LOGGER.info("ConcatFunctionExtension TestCase");
SiddhiManager siddhiManager = new SiddhiManager();

String inStreamDefinition = "define stream inputStream (symbol1 int, symbol2 double, symbol3 float, " +
"symbol4 long);";
String query = ("@info(name = 'query1') from inputStream select symbol1 , " +
"str:concat(symbol1,symbol2,symbol3,symbol4) as concatString " +
"insert into outputStream;");
SiddhiAppRuntime siddhiAppRuntime = siddhiManager.createSiddhiAppRuntime(inStreamDefinition + query);

siddhiAppRuntime.addCallback("query1", new QueryCallback() {
@Override
public void receive(long timeStamp, Event[] inEvents, Event[] removeEvents) {
EventPrinter.print(timeStamp, inEvents, removeEvents);
for (Event event : inEvents) {
count.incrementAndGet();
if (count.get() == 1) {
AssertJUnit.assertEquals("100101.121132.541000000", event.getData(1));
eventArrived = true;
}
if (count.get() == 2) {
AssertJUnit.assertEquals("1011011321000000", event.getData(1));
eventArrived = true;
}
}
}
});

InputHandler inputHandler = siddhiAppRuntime.getInputHandler("inputStream");
siddhiAppRuntime.start();
inputHandler.send(new Object[]{100, 101.121, 132.54f, 1000000L});
inputHandler.send(new Object[]{101, 101, 132, 1000000L});
SiddhiTestHelper.waitForEvents(100, 2, count, 60000);
AssertJUnit.assertEquals(2, count.get());
AssertJUnit.assertTrue(eventArrived);
siddhiAppRuntime.shutdown();
}

@Test(expectedExceptions = SiddhiAppCreationException.class)
public void testCoalesceFunctionExtensionWithOneArgument() throws InterruptedException {
LOGGER.info("ConcatFunctionExtension TestCase");
Expand Down