Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from static parser to a dynamic parser #71

Merged
merged 4 commits into from
Aug 6, 2019

Conversation

BuddhiWathsala
Copy link
Contributor

@BuddhiWathsala BuddhiWathsala commented Aug 6, 2019

Purpose

Resolve #56.

Goals

Previously we had that static parser which created as an operator prerequisite. If a user implements a custom extension the user unable to deploy apps in K8s since this static parser does not include that custom extension.

Approach

Here we integrate parser service to Siddhi runner and use it dynamically. At the Siddhi operator runtime, it runs as follow.

  • Starts the runner deployment with special system property (-Dsiddhi-parser)
  • Check health and call the parser
  • Retrieve parsed app and deploy
  • Remove the parser

Automation tests

  • Integration tests

    Update the E2E tests

Samples

Upgrade YAML examples to m2 version.

Test environment

minikube version: v1.2.0

test/e2e/siddhiprocess_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use manually built Siddhi Runner image's dependencies for passing Siddhi App
2 participants