Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape multiple entries of the same port return by the parser #99

Merged
merged 1 commit into from
Oct 5, 2019

Conversation

BuddhiWathsala
Copy link
Contributor

Purpose

K8s service creation returns an issue when we going to expose the same port more than twice. To fix this issue.

Goals

$subject

Approach

Create a slice to contain already exposed ports. If the given port is in that slice we are not going to expose it again.

Release note

Fix the issue of service creation, when the user gives the same port more than twise in the app.

Test environment

minikube version: v1.2.0

@suhothayan suhothayan merged commit 80592c1 into siddhi-io:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants