Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate mandatory parameter mismatch in annotation. #1362

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

suhothayan
Copy link
Contributor

Purpose

To make sure the docs are consistent and correct.

Approach

Validate mandatory parameter mismatch between ParameterOverload and 'optional' annotation.

Release note

Validate mandatory parameter mismatch in Extension annotations.

Validate mandatory parameter mismatch between ParameterOverload and 'optional' annotation.
@mohanvive mohanvive merged commit efff4cc into siddhi-io:master Jul 1, 2019
@codecov-io
Copy link

Codecov Report

Merging #1362 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1362      +/-   ##
============================================
- Coverage     60.49%   60.49%   -0.01%     
  Complexity       37       37              
============================================
  Files           632      632              
  Lines         26457    26457              
  Branches       4183     4183              
============================================
- Hits          16006    16005       -1     
- Misses         9069     9070       +1     
  Partials       1382     1382
Impacted Files Coverage Δ Complexity Δ
...y/processor/stream/window/SortWindowProcessor.java 91.04% <ø> (ø) 0 <0> (ø) ⬇️
...ream/function/Pol2CartStreamFunctionProcessor.java 67.64% <ø> (ø) 0 <0> (ø) ⬇️
...or/stream/window/LossyFrequentWindowProcessor.java 77.77% <ø> (ø) 0 <0> (ø) ⬇️
...l/extension/validator/InputParameterValidator.java 95.83% <100%> (+1.38%) 0 <0> (ø) ⬇️
...ut/stream/state/AbsentStreamPreStateProcessor.java 85.21% <0%> (-1.41%) 0% <0%> (ø)
...ocessor/stream/window/FrequentWindowProcessor.java 87.5% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0ffaa...868609d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants