-
Notifications
You must be signed in to change notification settings - Fork 938
start-time doesn't work in combination with autostart #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I got the same issue! |
Can you create a plunkr for this issue? By looking at this code, it should work as expected - https://github.com/siddii/angular-timer/blob/master/app/js/timer.js#L69 |
Sure! See the plunkr: http://embed.plnkr.co/1HnwmPd8CtgC5nW3HPt7/preview |
I made a PR solving this bug with proper test. See #109 |
Awesome... Thanks for the PR 👍 |
You could release a new minor version (1.1.7) with the fix and deploy the new example I have created at http://siddii.github.io/angular-timer/ |
Great! But the link pointing to issue in changelog is wrong, no? It should point to #101. |
Thanks for pointing out! Its fixed now :) |
;) |
This change seems to have broken the behaviour when both start-time and end-time are specified. It used to countdown as expected from end-time to start-time, now it starts counting forward. |
We are writing a kind of stopwatch application and having issues setting a start-time when autostart is set.
Simplified example:
The text was updated successfully, but these errors were encountered: