Skip to content

start-time doesn't work in combination with autostart #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
repher opened this issue Aug 4, 2014 · 11 comments
Closed

start-time doesn't work in combination with autostart #101

repher opened this issue Aug 4, 2014 · 11 comments

Comments

@repher
Copy link

repher commented Aug 4, 2014

We are writing a kind of stopwatch application and having issues setting a start-time when autostart is set.

Simplified example:

<timer autostart="false" interval="1000" start-time="1407143708781">
    {{ hhours }}:{{ mminutes }}:{{ sseconds }}
</timer>
@glaucocustodio
Copy link
Contributor

I got the same issue!

@siddii
Copy link
Owner

siddii commented Sep 16, 2014

Can you create a plunkr for this issue? By looking at this code, it should work as expected - https://github.com/siddii/angular-timer/blob/master/app/js/timer.js#L69

@glaucocustodio
Copy link
Contributor

Sure! See the plunkr: http://embed.plnkr.co/1HnwmPd8CtgC5nW3HPt7/preview

@glaucocustodio
Copy link
Contributor

I made a PR solving this bug with proper test. See #109

@siddii
Copy link
Owner

siddii commented Sep 17, 2014

Awesome... Thanks for the PR 👍

@siddii siddii closed this as completed Sep 17, 2014
@glaucocustodio
Copy link
Contributor

You could release a new minor version (1.1.7) with the fix and deploy the new example I have created at http://siddii.github.io/angular-timer/

@siddii
Copy link
Owner

siddii commented Sep 17, 2014

@glaucocustodio
Copy link
Contributor

Great! But the link pointing to issue in changelog is wrong, no? It should point to #101.

@siddii
Copy link
Owner

siddii commented Sep 17, 2014

Thanks for pointing out! Its fixed now :)

@glaucocustodio
Copy link
Contributor

;)

@cur3n4
Copy link

cur3n4 commented Nov 21, 2014

This change seems to have broken the behaviour when both start-time and end-time are specified. It used to countdown as expected from end-time to start-time, now it starts counting forward.

http://embed.plnkr.co/LDiTpZHCoSrZ2qpCN7x8/preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants