Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower_components should be bower-ignored or not checked in at all #30

Closed
tdumitrescu opened this issue Nov 19, 2013 · 3 comments
Closed

Comments

@tdumitrescu
Copy link
Contributor

Much like node_modules, this is bloat which will get copied over every time someone installs the package but isn't actually used. The Bower homepage recommends checking in dependencies only "If you aren't authoring a package that is intended to be consumed by others."

At the very least, the bower_components directory could be added to the ignore array in bower.json, which would allow you to keep the dependencies "locked" in the repo without getting copied over to every consumer of this package.

What do you think?

@siddii
Copy link
Owner

siddii commented Nov 20, 2013

Yep, makes sense. I will added in the next commit/release.

@tdumitrescu
Copy link
Contributor Author

sweet, thanks!

siddii added a commit that referenced this issue Nov 27, 2013
@siddii
Copy link
Owner

siddii commented Nov 27, 2013

@siddii siddii closed this as completed Nov 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants