Fix dynamic templating for Angular 1.2 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c template content</timer>), so that it can reference scope vars as within the timer's isolated scope.
|
Awesome... It works like a dream! I am merging it to the master. |
siddii
added a commit
that referenced
this pull request
Nov 27, 2013
Fix dynamic templating for Angular 1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix which should take care of #29
If the timer tag has dynamic content (e.g.,
<timer>my content with {{seconds}} etc</timer>), the controller now treats it the same way as it does in the default case (<timer/>, which inserts<span>{{millis}}</span>): it grabs the desired markup from the element and$compiles it with the timer's isolated scope; otherwise in Angular 1.2 it would get rendered with the parent scope and have no access to the timer's scope vars.This does wrap the dynamic content in
spantags so that Angular can compile it properly. Maybe it would make more sense for them to bedivs so that you could use almost any arbitrary markup within thetimertag.