Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add possibility to disable signOut endpoint for local provider #572

Merged

Conversation

anjarupnik
Copy link
Contributor

@anjarupnik anjarupnik commented Nov 14, 2023

Closes #555 .

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@zoey-kaiser
Copy link
Member

Hi @anjarupnik 👋

Thanks for the contribution! Could you please fix any merge conflicts? Then I can run the CI and do a review!

@anjarupnik
Copy link
Contributor Author

Hi @zoey-kaiser,
I am sorry, I forgot to pull the latest changes. Conflicts are resolved now.

@zoey-kaiser
Copy link
Member

I am sorry, I forgot to pull the latest changes. Conflicts are resolved now.

No need to apologize at all! We are super thankful for your contribution ❤️
Ill get around to testing this soon, then we can move forward and see if we want to merge this!

@zoey-kaiser zoey-kaiser merged commit 64e9001 into sidebase:main Nov 16, 2023
3 checks passed
@zoey-kaiser
Copy link
Member

zoey-kaiser commented Nov 16, 2023

Hi @anjarupnik

I just merged and released 0.6.1. You can install the new version and disable the signout api call 🥳

@anjarupnik
Copy link
Contributor Author

@zoey-kaiser top, thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to disable signOut endpoint
2 participants