-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies and add ModuleOptionsNormalized
type
#665
Conversation
So you wasted your own time adding the 660 changes to your PR when you could have merged mine and had me labelled as a contributor, seeing as though a create issues, comment on issues and do TRY to fix issues. |
I've closed that PR anyway, I won't waste my own time in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, however let's make a pre-release and verify the changes work in the nuxt-auth-example!
Would it be worth reopening my original OR for the VueUse issue? It seems beneficial and is a very minimal PR with minimal testing required so could be merged quite quickly. |
@codetheorist I see your point. However, I want to push a more general dependency revamp so that it unlocks the other PRs. There's nothing wrong with your PR. |
That in no way stated why my PR couldn't be merged and also didn't negate the fact that I'd already done the work, if even only 15 minutes (including searching for installs, update lock files), which was rendered pointless as you decided to do it again after seeing my already open PR. |
It's done now anyway but I'll be more reluctant to devote my time to issues and PRs within this repository moving forward. When people try to contribute, the least you can do is let them get the "contributor" badge to acknowledge them as such. |
Hi @codetheorist 👋
I think it is great that you are trying to contribute to open source projects, however I think that you also need to see this from our perspective. Our main goal is to continue developing NuxtAuth and we really appreciate help from outside contributors, however, if mergeing other PRs causes more work for us, then it is not worth it. I would also want to point out that this moment, that this PR was already opened, before you created your PR (taken, it did not include removing I would recommend discussing and pinging us in issues, before beginning to work on them. This way we can better coordinate with you, to ensure excess work is not done. |
Addresses known security advisories. Strengthens the type safety of the module.
Closes #660