fix(#808): only add error to response when it is set #809
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Potentially closes #808
β Type of change
π Description
After being redirected to the login page, the URL looks like this:
http://localhost:3000/login?callbackUrl=http://localhost:3000/dashboard&error=undefined
The error query parameter is undefined, and I would like to change this to a specific error message or remove it altogether.
We wrap the
error
heading inString()
and add a fallback toundefined
if it does not exist. However, transferring an error to a string will always result in it being set, as the wrapper undefined in string results in a string that is undefined, which lines up with the path generated!π Checklist