Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(#880): add signInHeaders param to SignIn #881

Merged

Conversation

dangercris
Copy link
Contributor

πŸ”— Linked issue

closes #880

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This Pull Request introduces enhancements to the sign-in functionality by enabling the inclusion of custom headers in the login request. The change is made to improve the flexibility and scalability of the sign-in process, allowing additional headers to be passed as part of the request for various purposes such as API versioning, custom authentication tokens, and enhanced security measures.

Key Changes

  • Custom Headers Support: The signIn function now accepts a signInHeaders parameter, which can be used to pass custom headers in the sign-in request.
  • Fallback to Default Headers: If no custom headers are provided, the function defaults to an empty object, maintaining backward compatibility.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@dangercris dangercris changed the title add signInHeaders param to SignIn enh(#880): add signInHeaders param to SignIn Aug 23, 2024
Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: 1ee3cd2

pnpm add https://pkg.pr.new/@sidebase/nuxt-auth@881

Open in Stackblitz

@zoey-kaiser zoey-kaiser merged commit 8df1465 into sidebase:main Aug 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add headers for local strategy in SignIn
2 participants