Fix usage of ActiveJob::Base.queue_name #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `activejob` the class method `MyJob.queue_name` returns a `Proc`. To obtain the actual queue name, we need to invoke the method on an instance of the job class, e.g. `MyJob.new.queue_name`. The test suite was unable to detect this problem because a mocked version of the `ActiveJob::Base` class was used which did not act in the same way as the actual `activejob` gem. We fix this by testing against the actual `activejob` gem. Fixes sidekiq-cron#512.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
activejobthe class methodMyJob.queue_namereturns aProc. To obtain the actual queue name, we need to invoke the method on an instance of the job class, e.g.MyJob.new.queue_name.The test suite was unable to detect this problem because a mocked version of the
ActiveJob::Baseclass was used which did not act in the same way as the actualactivejobgem.We fix this by testing against the actual
activejobgem.Fixes #512.