fix: verify CSR signature before issuing a certificate #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to make sure that the CSR was generated by the owner of the private key. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
|
/approve |
andrewrynhard
approved these changes
Apr 26, 2021
|
/lgtm |
smira
added a commit
to smira/talos
that referenced
this pull request
Apr 27, 2021
See siderolabs/crypto#11 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
talos-bot
pushed a commit
to siderolabs/talos
that referenced
this pull request
Apr 27, 2021
See siderolabs/crypto#11 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
added a commit
to smira/talos
that referenced
this pull request
May 5, 2021
See siderolabs/crypto#11 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit d540a4a)
smira
added a commit
to smira/talos
that referenced
this pull request
May 5, 2021
See siderolabs/crypto#11 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit d540a4a)
smira
added a commit
to siderolabs/talos
that referenced
this pull request
May 5, 2021
See siderolabs/crypto#11 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit d540a4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to make sure that the CSR was generated by the owner of
the private key.
Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com