-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace static buffer allocation on growth #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMV
reviewed
Jan 30, 2025
DmitriyMV
reviewed
Jan 30, 2025
DmitriyMV
reviewed
Jan 30, 2025
DmitriyMV
reviewed
Jan 30, 2025
Use `slices.Grow` and follow whatever algorithm it uses internally to pick the next size of the buffer. So the growth might not be exactly what we asked for, but it should be optimal from Go runtime point of view. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
13559d6
to
015a398
Compare
DmitriyMV
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒
No real changes with the benchmark:
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
slices.Grow
and follow whatever algorithm it uses internally to pick the next size of the buffer.So the growth might not be exactly what we asked for, but it should be optimal from Go runtime point of view.