fix: unexpected short read error #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is to use `io.ReadFull`, as we expect the source to read the full buffer, but we used `Read()` which is not guaranteed to read the full buffer. It shows up with Talos in the tests. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/tail-read-full-bug
branch
from
8b10dc6 to
7cb7294
Compare
frezbo
approved these changes
May 20, 2024
Unix4ever
approved these changes
May 20, 2024
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
May 20, 2024
See siderolabs/go-tail#2 It seems to pop up more with compressed logs, but overall makes sense to be fixed. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
May 28, 2024
See siderolabs/go-tail#2 It seems to pop up more with compressed logs, but overall makes sense to be fixed. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit d430704)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is to use
io.ReadFull, as we expect the source to read the full buffer, but we usedRead()which is not guaranteed to read the full buffer.It shows up with Talos in the tests.