Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to generate secure boot ISO with custom kernel args #104

Closed
TimJones opened this issue Apr 10, 2024 · 0 comments · Fixed by #105
Closed

Unable to generate secure boot ISO with custom kernel args #104

TimJones opened this issue Apr 10, 2024 · 0 comments · Fixed by #105
Assignees
@smira
Labels
bug Something isn't working

Comments

@TimJones
Copy link
Member

Generating a secureboot ISO works fine with the default schematic, but when I add custom kernel args (e.g. talos.experiment.wipe=system) the secureboot ISO fails to generate.

schematic ID: 9acd4f2454d4969f5351e85d824eb5d27f8124b56d281d8a03c924fa1a7cfd2f

customization:
  extraKernelArgs:
    - talos.experimental.wipe=system

The standard ISO download works, but the secureboot ISO download fails.
@TimJones TimJones added the bug Something isn't working label Apr 10, 2024
@smira smira self-assigned this Apr 10, 2024
smira added a commit to smira/talos that referenced this issue Apr 10, 2024
@smira
fix: generate secureboot ISO .der certificate correctly
55c9c94 
Previous approach relied on a field which is _only_ present if
file-based PKI is passed in, and fails for e.g. Azure KMS.

See siderolabs/image-factory#104

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira added a commit to smira/talos that referenced this issue Apr 10, 2024
@smira
fix: generate secureboot ISO .der certificate correctly
bcd40c3 
Previous approach relied on a field which is _only_ present if
file-based PKI is passed in, and fails for e.g. Azure KMS.

See siderolabs/image-factory#104

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira mentioned this issue Apr 10, 2024
Merged
smira added a commit to smira/talos that referenced this issue Apr 10, 2024
@smira
fix: generate secureboot ISO .der certificate correctly
909a580 
Previous approach relied on a field which is _only_ present if
file-based PKI is passed in, and fails for e.g. Azure KMS.

See siderolabs/image-factory#104

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira added a commit to smira/image-service that referenced this issue Apr 10, 2024
@smira
fix: generation of SecureBoot ISO
d4c1053 
Fixes siderolabs#104

Pull in Talos with a fix siderolabs/talos#8571

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira mentioned this issue Apr 10, 2024
Merged
smira added a commit to smira/talos that referenced this issue Apr 12, 2024
@smira
fix: generate secureboot ISO .der certificate correctly
7d24ddd 
Previous approach relied on a field which is _only_ present if
file-based PKI is passed in, and fails for e.g. Azure KMS.

See siderolabs/image-factory#104

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 909a580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smira smira

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: generation of SecureBoot ISO smira/image-service
2 participants
@smira @TimJones