Skip to content

Commit

Permalink
fix: pin apexcharts version to 3.45.2
Browse files Browse the repository at this point in the history
The most recent apexcharts version seems to have a bug and doesn't work
well with vue3-apexcharts wrapper. Size of charts is different, there's
an exception with negative svg sizes before it draws the chart for the
first time.

vue3-apexcharts seem to pull the latest version always, so pin it
explicitly to 3.45.2.

Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
  • Loading branch information
Unix4ever committed Sep 11, 2024
1 parent e3d46f9 commit f83cf3b
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
Binary file modified frontend/bun.lockb
Binary file not shown.
3 changes: 2 additions & 1 deletion frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"vue-virtual-scroller": "^2.0.0-beta.8",
"vue-word-highlighter": "^1.2.4",
"vue3-apexcharts": "^1.5.3",
"vue3-popper": "^1.5.0"
"vue3-popper": "^1.5.0",
"apexcharts": "3.45.2"
},
"devDependencies": {
"@heroicons/vue": "^2.1.3",
Expand Down
1 change: 1 addition & 0 deletions frontend/src/components/common/Charts/RadialBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ const colors = [

const options: Ref<ApexOptions> = computed(() => {
return {
chart: {},
yaxis: {
max: total?.value ?? 0,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@ included in the LICENSE file.
import { computed, toRefs } from "vue";
import ApexChart from "vue3-apexcharts";
import { primary, naturals } from "@/vars/colors";
import { ApexOptions } from "apexcharts";

const props = defineProps<{ chartFillPercents: number | string }>();

const { chartFillPercents } = toRefs(props);
const options = {
const options: ApexOptions = {
chart: {
dropShadow: {
enabled: true,
Expand All @@ -39,7 +40,7 @@ const options = {
radialBar: {
hollow: {
margin: 0,
size: 60,
size: "60",
},
track: {
background: naturals.N0
Expand All @@ -50,7 +51,7 @@ const options = {
},
},
fill: {
colors: primary.P3,
colors: [primary.P3],
},
stroke: {
lineCap: "round"
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/views/omni/Auth/Authenticate.vue
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ import UserInfo from "@/components/common/UserInfo/UserInfo.vue";
import { withMetadata } from "@/api/options";
import { fetchOption } from "@/api/fetch.pb";
import { Code } from "@/api/google/rpc/code.pb";
import { Auth0VueClient } from "@auth0/auth0-vue/src/global";
import { Auth0VueClient } from "@auth0/auth0-vue";

const user = ref<User | undefined>(undefined);
let idToken = "";
Expand Down

0 comments on commit f83cf3b

Please sign in to comment.