-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let's add side-by-side with "official" protobuf marshaling #2
Comments
DmitriyMV
added a commit
that referenced
this issue
Jul 26, 2022
This tests ensures that our encoding is compatible with official proto modules. Closes #2
DmitriyMV
added a commit
that referenced
this issue
Jul 26, 2022
This tests ensures that our encoding is compatible with official proto modules. Closes #2 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
that referenced
this issue
Jul 26, 2022
This tests ensures that our encoding is compatible with official proto modules. Closes #2 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
that referenced
this issue
Jul 26, 2022
This tests ensures that our encoding is compatible with official proto modules. Closes #2 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
that referenced
this issue
Jul 26, 2022
This test ensures that our encoding is compatible with official proto modules. It doesn't verify that binary form is equivalent because we do encode zero values, unlike official encoder. Also add simple fuzzing. Closes #2 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
that referenced
this issue
Jul 26, 2022
This test ensures that our encoding is compatible with official proto modules. It doesn't verify that binary form is equivalent because we do encode zero values, unlike official encoder. Also add simple fuzzing. Closes #2 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Task
We should ensure that our encoder/decoder works with binary data and structs produced by official protobuf compiler. For that each test should basically contain the following.
protobuf
from proto messages usingproto.Unmarshal
proto.Marshal
The following test cases should be implemented:
anyof
and to lesser extentenum
are not supported for now.Questions
The text was updated successfully, but these errors were encountered: