-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[upgrade-k8s] images paths overwrite by const while using private registries #8275
Comments
Yes, this is not supported as of right now, but you have two ways to get around it:
|
Hello @smira! Thank you to answer.
That is why we have forked and tested a change ton the code. The PR will come in a couple of minutes. |
We have even docs for Harbor, I'm pretty sure it works: https://www.talos.dev/v1.6/talos-guides/configuration/pull-through-cache/#using-harbor-as-a-caching-registry |
Reuse custom registry if not public one Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
feat: private registry for k8s upgrade. Reuse custom registry if not public one Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
Reuse custom registry Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
Reuse custom registry. Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
Reuse custom registry. Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
Reuse custom registry. Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
add upgrade flag manage proxy image Fixes: siderolabs#8275
New flag. Proxy image management. Fixes: siderolabs#8275 Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
New flag. Proxy image management. Fixes: siderolabs#8275 Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
Reuse custom registry. New flag Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com>
Allows to use custom registry/images. Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Allows to use custom registry/images. Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit 3fe82ec)
Allows to use custom registry/images. Fixes: siderolabs#8275 Co-authored-by: @g3offrey Signed-off-by: Matthieu STROHL <mstrohl@dive-in-it.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Bug Report
Unable to kee private registry image path on upgrade-k8s command
Description
The command line "talosctl upgrade-k8s --to xxxx" replaced images repository to the default public registry instead of changing tag only
Logs
Environment
talosctl version --nodes <problematic nodes>
]1.6.3
kubectl version --short
]1.28.2 to 1.29.0
VM on OpenStack
The text was updated successfully, but these errors were encountered: