-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the schematic ID in a node annotation #9089
Comments
See #9070, if the extensions will be exposed via node labels, the schematic will be exposed as wll. |
@smira one issue is the schematic id is too long for a node label (siderolabs/image-factory#126) |
yeah, true, I believe annotations have same limits (?). Certainly some extensions make more sense as labels (e.g. "I have nvidia"), while schematic is fine as an annotation (as it makes less sense to filter on it) |
Annotations can be up to 256kb |
thanks @tjwallace, so it sounds like we'd need to split them across labels/annotations based on extension version length (as schematic virtual extension has schematic ID as a version). That doesn't sound too bad for me. |
$ kubectl describe nodes talos-default-worker-1
Name: talos-default-worker-1
Roles: <none>
Labels: beta.kubernetes.io/arch=amd64
extensions.talos.dev/spin=v0.13.1
... |
Extensions are posted the following way: `extentions.talos.dev/<name>=<version>` The name should be valid as a label (annotation) key. If the value is valid as a label value, use labels, otherwise use annotations. Also implements node annotations in the machine config as a side-effect. Fixes siderolabs#9089 Fixes siderolabs#8971 See siderolabs#9070 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Extensions are posted the following way: `extentions.talos.dev/<name>=<version>` The name should be valid as a label (annotation) key. If the value is valid as a label value, use labels, otherwise use annotations. Also implements node annotations in the machine config as a side-effect. Fixes siderolabs#9089 Fixes siderolabs#8971 See siderolabs#9070 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Feature Request
Put the schematic ID in a node annotation
Description
It would be helpful for automations like
system-upgrade-controller
to have the Talos schematic ID in a node annotations (iecluster.talos.dev/schematic-id
) so it can be used to pull the correct installer image.Currently my cluster needs two different schematic IDs so I cannot set a single value in my
system-upgrade-controller
plan.Thanks!
The text was updated successfully, but these errors were encountered: