Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust Talos resolver to use upstream as a fallback #9613

Closed
Tracked by #9610
smira opened this issue Oct 31, 2024 · 0 comments · Fixed by #9723
Closed
Tracked by #9610

adjust Talos resolver to use upstream as a fallback #9613

smira opened this issue Oct 31, 2024 · 0 comments · Fixed by #9723
Assignees
@smira

Comments

@smira
Copy link
Member

smira commented Oct 31, 2024 •
edited
Loading

There's a mismatch between Talos docker resolver and containerd one: containerd defaults to having original endpoint (e.g. ghcr.io) as a fallback, while Talos doesn't.

Talos resolver is used to pull installer, etcd, kubelet images, while containerd pulls all other images.

Note: this statement might need additional verification.
@smira smira mentioned this issue Oct 31, 2024
Closed
@smira smira changed the title adjust Talos resolver to use upstream as a fallbck adjust Talos resolver to use upstream as a fallback Oct 31, 2024
@smira smira self-assigned this Nov 14, 2024
smira added a commit to smira/talos that referenced this issue Nov 14, 2024
@smira
fix: registry mirror fallback handling
bb0ad93 
Fixes siderolabs#9613

This has two changes:

* adjust Talos registry resolver to match containerd (CRI) resolver: use
  by default upstream as a fallback
* add a machine config option to skip upstream as a fallback, and adjust
  CRI configuration accordingly

See https://github.com/containerd/containerd/blob/main/docs/hosts.md#registry-configuration---examples
for details on CRI's `hosts.toml`.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira mentioned this issue Nov 14, 2024
Merged
smira added a commit to smira/talos that referenced this issue Nov 14, 2024
@smira
fix: registry mirror fallback handling
fb727c2 
Fixes siderolabs#9613

This has two changes:

* adjust Talos registry resolver to match containerd (CRI) resolver: use
  by default upstream as a fallback
* add a machine config option to skip upstream as a fallback, and adjust
  CRI configuration accordingly

See https://github.com/containerd/containerd/blob/main/docs/hosts.md#registry-configuration---examples
for details on CRI's `hosts.toml`.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: registry mirror fallback handling smira/talos
1 participant
@smira