Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to patch containerd CRI base OCI spec #9827

Closed
Tracked by #9825 ...
smira opened this issue Nov 28, 2024 · 0 comments · Fixed by #9834
Closed
Tracked by #9825 ...

allow to patch containerd CRI base OCI spec #9827

smira opened this issue Nov 28, 2024 · 0 comments · Fixed by #9834
Assignees

Comments

@smira
Copy link
Member

smira commented Nov 28, 2024

From containerd config:

      # base_runtime_spec is a file path to a JSON file with the OCI spec that will be used as the base spec that all
      # container's are created from.
      # Use containerd's `ctr oci spec > /etc/containerd/cri-base.json` to output initial spec file.
      # Spec files are loaded at launch, so containerd daemon must be restarted on any changes to refresh default specs.
      # Still running containers and restarted containers will still be using the original spec from which that container was created.
      base_runtime_spec = ""

Idea: Talos generates base OCI spec, and merge machine configuration patches supplied by the user, building a final base OCI spec which will be used by the CRI.

This allows e.g. to change default ulimits for containers, or in general any OCI settings which are not configurable in Kubernetes.

@smira smira self-assigned this Nov 28, 2024
smira added a commit to smira/talos that referenced this issue Nov 28, 2024
Fixes siderolabs#9827

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira added a commit to smira/talos that referenced this issue Nov 28, 2024
Fixes siderolabs#9827

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant