chore: add generic methods and use them 1/n #5702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMV
force-pushed
the
generics
branch
3 times, most recently
from
4257b51 to
1b26e09
Compare
DmitriyMV
changed the title
DmitriyMV
changed the title
DmitriyMV
changed the title
utkuozdemir
reviewed
Jun 7, 2022
DmitriyMV
force-pushed
the
generics
branch
5 times, most recently
from
2a1c72e to
3703402
Compare
utkuozdemir
reviewed
Jun 8, 2022
utkuozdemir
approved these changes
Jun 8, 2022
DmitriyMV
force-pushed
the
generics
branch
3 times, most recently
from
ffcc59f to
1f056fc
Compare
Things like ToSet, Keys etc... Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
|
/m |
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Jun 9, 2022
Use things from siderolabs#5702. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Jun 9, 2022
Use things from siderolabs#5702. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Jun 9, 2022
Use things from siderolabs#5702. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Jun 9, 2022
Use things from siderolabs#5702. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
added a commit
to DmitriyMV/talos
that referenced
this pull request
Jun 9, 2022
Use things from siderolabs#5702. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things like ToSet, Keys etc...
Signed-off-by: Dmitriy Matrenichev dmitry.matrenichev@siderolabs.com
This change is