fix: revert: set rlimit explicitly in wrapperd #7208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
changed the title
This reverts commit a2565f6. The fix done in `a2565f67`, was actually a no-op caused by the misunderstanding the fix done in Go and backported to [Go 1.20.4](golang/go@ecf7e00). The fix gave a false confidence that it was working when it was tested against Talos `main` branch since the PR siderolabs#7190 bumped `x/sys` package from [v0.7.0 -> v0.8.0](golang/go@ecf7e00), the actual change in `x/sys` can be found here at https://cs.opensource.google/go/x/sys/+/ff18efa0a3fa22d4fede381b822bbcfe53b7ee7c which meant that when updating Go to 1.20.4 the `x/sys` package should been updated too. The `x/sys` package changed how the syscall to set the rlimit was called, it got moved into the Go stdlib instead of calling rlimit syscall in the `x/sys` package, which meant a combination of using Go 1.20.4 and an older `x/sys` package means `RLIMIT_NOFILE` value would not be set back to the original value. The Talos 1.4 release branch currently have `x/sys` at [v0.7.0(https://github.com/siderolabs/talos/blob/v1.4.3/go.mod#L133), so the backport would consist of this change along another commit bumping `x/sys` package to `v0.8.0`. Fixes: siderolabs#7198 Fixes: siderolabs#7206 Co-authored-by: Utku Ozdemir <utku.ozdemir@siderolabs.com> Signed-off-by: Noel Georgi <git@frezbo.dev>
DmitriyMV
approved these changes
May 11, 2023
rsmitty
approved these changes
May 11, 2023
|
/m |
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
May 11, 2023
Bump `x/sys` to v0.8.0 for a complete fix for siderolabs#7208 in the release-1.4 branch. See https://cs.opensource.google/go/x/sys/+/ff18efa0a3fa22d4fede381b822bbcfe53b7ee7c Signed-off-by: Noel Georgi <git@frezbo.dev>
Merged
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
May 11, 2023
Bump `x/sys` to v0.8.0 for a complete fix for siderolabs#7208 in the release-1.4 branch. See https://cs.opensource.google/go/x/sys/+/ff18efa0a3fa22d4fede381b822bbcfe53b7ee7c Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
May 11, 2023
Bump `x/sys` to v0.8.0 for a complete fix for siderolabs#7208 in the release-1.4 branch. See https://cs.opensource.google/go/x/sys/+/ff18efa0a3fa22d4fede381b822bbcfe53b7ee7c Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
May 12, 2023
Bump `x/sys` to v0.8.0 for a complete fix for siderolabs#7208 in the release-1.4 branch. See https://cs.opensource.google/go/x/sys/+/ff18efa0a3fa22d4fede381b822bbcfe53b7ee7c Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
added a commit
to frezbo/talos
that referenced
this pull request
May 12, 2023
Bump `x/sys` to v0.8.0 for a complete fix for siderolabs#7208 in the release-1.4 branch. See https://cs.opensource.google/go/x/sys/+/ff18efa0a3fa22d4fede381b822bbcfe53b7ee7c Signed-off-by: Noel Georgi <git@frezbo.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a2565f6.
The fix done in
a2565f67, was actually a no-op caused by the misunderstanding the fix done in Go and backported to Go 1.20.4. The fix gave a false confidence that it was working when it was tested against Talosmainbranch since the PR #7190 bumpedx/syspackage from v0.7.0 -> v0.8.0, the actual change inx/syscan be found here at https://cs.opensource.google/go/x/sys/+/ff18efa0a3fa22d4fede381b822bbcfe53b7ee7c which meant that when updating Go to 1.20.4 thex/syspackage should been updated too. Thex/syspackage changed how the syscall to set the rlimit was called, it got moved into the Go stdlib instead of calling rlimit syscall in thex/syspackage, which meant a combination of using Go 1.20.4 and an olderx/syspackage meansRLIMIT_NOFILEvalue would not be set back to the original value.The Talos 1.4 release branch currently have
x/sysat [v0.7.0(https://github.com/siderolabs/talos/blob/v1.4.3/go.mod#L133), so the backport would consist of this change along another commit bumpingx/syspackage tov0.8.0.Fixes: #7198
Fixes: #7206