chore: optimize DNSResolveCacheController #8577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize `DNSResolveCacheController` type, including `dns.Server` optimization for easy start/stop. This PR ensures that we delete server from runners on stop (even unexpected) and restart it properly. Also fixes incorrect assumption on unit-tests. Fixes siderolabs#8563 This PR also does those things: - Removes `utils.Runner` - Removes `ctxutil.MonitorFn` - Removes `dns.Runner` - Removes `network.dnsRunner` Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
force-pushed
the
dns-cache-fix
branch
from
c793e15 to
ba7cdc8
Compare
smira
approved these changes
Apr 10, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize
DNSResolveCacheControllertype, includingdns.Serveroptimization for easy start/stop. This PR ensures that we delete server from runners on stop (even unexpected) and restart it properly. Also fixes incorrect assumption on unit-tests.Fixes #8563
This PR also does those things:
utils.Runnerctxutil.MonitorFndns.Runnernetwork.dnsRunner