chore: move to containerd 2.0 API #8766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
added a commit
to smira/go-talos-support
that referenced
this pull request
May 21, 2024
Use a constant from Talos machinery to avoid importing containerd API. Required for siderolabs/talos#8766 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
chore/containerd-2.0
branch
2 times, most recently
from
47424a2
to
888e56b
Compare
|
/ok-to-test |
smira
force-pushed
the
chore/containerd-2.0
branch
3 times, most recently
from
28efc43
to
5bacc9d
Compare
smira
added a commit
to smira/talos
that referenced
this pull request
May 22, 2024
This only updates the binaries, the API update will be handled via PR siderolabs#8766. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
May 22, 2024
This only updates the binaries, the API update will be handled via PR siderolabs#8766. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
May 22, 2024
This only updates the binaries, the API update will be handled via PR siderolabs#8766. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
chore/containerd-2.0
branch
2 times, most recently
from
8e28668
to
1c9075d
Compare
frezbo
reviewed
May 24, 2024
| @@ -95,11 +92,6 @@ func Pull(ctx context.Context, reg config.Registries, client *containerd.Client, | |||
| containerd.WithPullUnpack, | |||
| containerd.WithResolver(resolver), | |||
| containerd.WithChildLabelMap(images.ChildGCLabelsFilterLayers), | |||
| containerd.WithUnpackOpts( | |||
| []containerd.UnpackOpt{ | |||
| containerd.WithUnpackDuplicationSuppressor(unpackDuplicationSuppressor), | |||
There was a problem hiding this comment.
we can't use it anymore (as the required parts became private), but I don't think we need it, as this is only needed when multiple requests for the same image to be pulled arrive.
There was a problem hiding this comment.
and it's only an optimization - it makes such pull operations run faster
frezbo
approved these changes
May 24, 2024
Lots of module moves/renames. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
chore/containerd-2.0
branch
from
1c9075d
to
c2b19dc
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of module moves/renames.