fix: panic in osroot controller #8772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
May 21, 2024
Unix4ever
approved these changes
May 21, 2024
Fixes siderolabs#8753 There seems to be a problem in the machine config anyways, as `machine.ca.crt` is missing for the worker (this should break `apid` connectivity), but still Talos controller shouldn't enter a panic loop. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/panic-osroot-controller
branch
from
9deeba8
to
ce8c86d
Compare
|
/m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8753
There seems to be a problem in the machine config anyways, as
machine.ca.crtis missing for the worker (this should breakapidconnectivity), but still Talos controller shouldn't enter a panic loop.