chore: use new disks api for iscsi tests #8905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
force-pushed
the
chore/fix-iscsi-tests
branch
7 times, most recently
from
5e48491 to
311ece6
Compare
The iscsi test broke when the new disks api was introduced making the test pass always, now filter other only `iscsi` disk types using the new disks API. Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
force-pushed
the
chore/fix-iscsi-tests
branch
from
311ece6 to
86a3222
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iscsi test broke when the new disks api was introduced making the test pass always, now filter other only
iscsidisk types using the new disks API.