fix: host DNS access with firewall enabled #9233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly enable access to host DNS from pod/service IPs. Also fix the Kubernetes health checks to assert number of ready pods to match expectation, otherwise the check might skip a pod (e.g. `kube-proxy` one) which is not ready, allowing the test to proceed too early. Update DNS test to print more logs on error. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
|
Split from #8901 |
frezbo
approved these changes
Aug 27, 2024
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 12, 2024
The fix in siderolabs#9233 wasn't correct, as it was looking for number of replicas in a "random" ReplicaSet. If the deployment has multiple replica sets, it leads to unexpected results. Instead, read the Deployment resource directly. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch fix/coredns-check # Changes to be committed: # modified: pkg/cluster/check/default.go # modified: pkg/cluster/check/kubernetes.go # # Untracked files: # cert.pem # cgroup.tar # cgrp/ # cilium.yaml # csr.pem # dict # experiment/ # extensions.patch # host-dns-endpoints.yaml # privkey.pem # secrets.yaml # siderolink.yaml # state.test # talos-in-talos.yaml # watchdog.yaml #
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 12, 2024
The fix in siderolabs#9233 wasn't correct, as it was looking for number of replicas in a "random" ReplicaSet. If the deployment has multiple replica sets, it leads to unexpected results. Instead, read the Deployment resource directly. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 12, 2024
The fix in siderolabs#9233 wasn't correct, as it was looking for number of replicas in a "random" ReplicaSet. If the deployment has multiple replica sets, it leads to unexpected results. Instead, read the Deployment resource directly. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 13, 2024
The fix in siderolabs#9233 wasn't correct, as it was looking for number of replicas in a "random" ReplicaSet. If the deployment has multiple replica sets, it leads to unexpected results. Instead, read the Deployment resource directly. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit 780a1f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly enable access to host DNS from pod/service IPs.
Also fix the Kubernetes health checks to assert number of ready pods to match expectation, otherwise the check might skip a pod (e.g.
kube-proxyone) which is not ready, allowing the test to proceed too early.Update DNS test to print more logs on error.