Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement "$patch: delete" logic #9275

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

DmitriyMV
Copy link
Member

@DmitriyMV DmitriyMV commented Sep 4, 2024

This PR implements "delete patches", same as in k8s.

@DmitriyMV DmitriyMV force-pushed the patch-delete branch 6 times, most recently from a9ef7c4 to 9a32b78 Compare September 5, 2024 19:36
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very 🆒

we need to add docs:

  • to the config patching document to explain $patch: delete
  • and add to hack/release.toml a note about new feature

DmitriyMV added a commit to DmitriyMV/talos that referenced this pull request Sep 6, 2024
Required for siderolabs#9275

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV added a commit to DmitriyMV/talos that referenced this pull request Sep 6, 2024
Required for siderolabs#9275

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV DmitriyMV force-pushed the patch-delete branch 2 times, most recently from 3e2737d to d163fc6 Compare September 9, 2024 10:19
This PR implements "delete patches", same as in k8s.

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV
Copy link
Member Author

@smira done! Good to go?

@DmitriyMV
Copy link
Member Author

/m

@talos-bot talos-bot merged commit 899f1b9 into siderolabs:main Sep 9, 2024
52 checks passed
@DmitriyMV DmitriyMV deleted the patch-delete branch September 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants