feat: support generating disk images with image cache #9778
+108
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing i can think of is if the image cache is too large, the disk image creation would fail since we set a default sparse file of almost 1.3gig imageOptions:
diskSize: 1306525696 |
frezbo
commented
Nov 21, 2024
frezbo
commented
Nov 21, 2024
frezbo
force-pushed
the
feat/imager-disk-cache-gen-support
branch
from
28bc5f5 to
2c94946
Compare
dsseng
approved these changes
Nov 21, 2024
Closed
Add support for generating disk images with image cache. Fixes: siderolabs#9616 Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
force-pushed
the
feat/imager-disk-cache-gen-support
branch
from
2c94946 to
1bac0b1
Compare
smira
approved these changes
Nov 26, 2024
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generating disk images with image cache.
Fixes: #9616