fix: fix e2e test with extensions and SELinux #9803
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip SELinux test when system extensions are active, we'll work on that in a bit. Also elaborate more on SELinux test errors. Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
frezbo
reviewed
Nov 26, 2024
| @@ -152,6 +153,13 @@ func (suite *SELinuxSuite) checkFileLabels(nodes []string, expectedLabels map[st | |||
| suite.T().Skip("skipping SELinux test since SELinux is disabled") | |||
| } | |||
|
|
|||
| // TODO: do not skip the test if system extensions are enabled | |||
There was a problem hiding this comment.
probably easier to check if either extensions.qemu or extensions.nvidia is set
There was a problem hiding this comment.
But what if we just run locally? Well, for CI that'd suffice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip SELinux test when system extensions are active, we'll work on that in a bit. Also elaborate more on SELinux test errors.
Signed-off-by: Dmitry Sharshakov dmitry.sharshakov@siderolabs.com