-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update image-cache doc for iso #9929
base: main
Are you sure you want to change the base?
Conversation
minSize: 2GB | ||
maxSize: 2GB | ||
``` | ||
|
||
In this example, image cache volume is provisioned on the system disk with a fixed size of 2GB. | ||
In this example, image cache volume is provisioned on the system disk with a fixed size of 2GB (default is 1GB). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default is actually 1.3Gb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the actual defaults are:
talos/internal/app/machined/pkg/controllers/cri/image_cache_config.go
Lines 102 to 104 in 470b755
MinImageCacheSize = 500 * 1024 * 1024 // 500MB | |
MaxImageCacheSize = 1 * 1024 * 1024 * 1024 // 1GB | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it pick between min and max?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it picks a value in between leaning towards max if space is available, but it will never allocated less than min
@@ -36,14 +36,17 @@ There are two supported boot asset types for the Image Cache: ISO and disk image | |||
|
|||
### ISO | |||
|
|||
> Note: ISO image cache only works with iso9660 filesystems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does it mean by an iso9660
, I guess virtual cdroms are not so much used as an option, also newer ISO support something called File System Transposition and are not really supposed to be dd
'ed to a disk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to fix this one way or another, but I'm confused a bit about the method. We should document what is the supported method of moving an ISO to a USB stick, and the one we support here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we have a plan going to support two things:
dd
the ISO to the USB stick (already works without issues)- copy the ISO contents to the VFAT usb stick (need some changes to support that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was basing this off what I was seeing on my physical hardware in the various tests. It only seemed to work when the detected filesystem was iso9660 but I didn't exhaustively test what's available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dd
the ISO to the USB stick (already works without issues)
When I dd
the iso to usb the usb drive showed up as sda1 and I don't think the cache was used during provisioning. I can test again if you think this should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you did something wrong there, we tested with ISO, and it works and is detected. we have another way coming up, I will update your PR once it's tested
c3a38b5
to
06d4cf1
Compare
If we're going to make this work with USB drives before 1.9 comes out then we can close this PR and focus on one with alternate instructions for USB. |
@rothgar I'm going to update this a bit with recent fixes and push back to your branch. |
Clarifying information from siderolabs#9892 Signed-off-by: Justin Garrison <justin.garrison@siderolabs.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Clarifying information from #9892