-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked interface #5
Conversation
But of course: Everything at an early prototyping stage. |
I love it. |
Amazing. Love it!!! Just a question about --as_tsv: Shouldn't that be a sub-option for the "list" subcommand (or module?) Or are you currently not working with subcommand-specific options? Perhaps that's making things too complicated, but it would be somewhat more logical to have command-specific options, in my view. Just thinking loud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not following every bit here. I'd like to review more carefully the command line option interface at some point, but I don't see myself doing that anytime soon, so I suggest we move on and I check it out, or discuss with you, at some later timepoints.
I think I will merge this now and I have two additional things on my mind:
|
Out of curiosity, how does the map react if you place a point in an area that does not get drawn by default (e.g. New Zealand)? Is that point added, or do you currently simply replace |
Ah - a classic. I'm confident from the implementation that all and every sample point will be plotted no matter if it is on land or not. The code just splits the word into a grid and checks if there is a (or multiple) sample in a particular cell. If so, then we get an X. |
Here's a suggestion for a better interface in accordance to #4.
I think it's neat. Fight me! 😄