-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connection.stream
does not close in Bun
#2884
Comments
Hi, @steelywing. Thanks for the report. This issue is reflected in MySQL2 internal tests too: node-mysql2/test/integration/connection/test-select-ssl.test.cjs Lines 25 to 28 in 3659488
I haven't had time to check whether this should be an error to be reported in Bun or handled directly in MySQL2. However, in the short research I've done, this seems to be related to the way Bun handles callbacks. |
Is this related to my issue? oven-sh/bun#12155 |
Unfortunately, I can't see which version of Bun started this, but this error was introduced later (before some specific version, it worked normally). Looking at what has changed in this version could help clarify what happened (some Bun release around 24/01/18). |
I found the cause is if socket is FIN from the other side, the I have a question from this code, is it better call Line 894 in ac76a5d
|
@steelywing, it seems that Bun has fixed this bug in oven-sh/bun#13212. After they release it, I'll revisit MySQL2 tests 🚀 |
I cannot confirm this is Bun bug or mysql2 bug
Reproduce:
the doc says we only need to call
connection.end()
, but that function does not end the net stream in BunRelated: oven-sh/bun#11414
The text was updated successfully, but these errors were encountered: