connection.stream does not close in Bun

[steelywing]

I cannot confirm this is Bun bug or mysql2 bug

Reproduce:

// Get the client
import mysql from 'mysql2/promise';

// Create the connection to database
const connection = mysql.createConnection({
    host: 'localhost',
    user: 'test',
    password: 'password',
    database: 'test',
});

try {
} catch (err) {
    console.log(err);
} finally {
    // this does not call `connection.stream.end()` in Bun
    await connection.end();
}

console.log("end");

// if comment out this line, `stream.end()` does not be called in Bun, 
// so Bun will not exit, but node.js will exit normally
connection.connection.close();

the doc says we only need to call connection.end(), but that function does not end the net stream in Bun

Related: oven-sh/bun#11414

[wellwelwel]

Hi, @steelywing. Thanks for the report.

This issue is reflected in MySQL2 internal tests too:

node-mysql2/test/integration/connection/test-select-ssl.test.cjs

Lines 25 to 28 in 3659488

	connection.end((err) => {
	assert.ifError(err);
	process.exit(0);
	});

• Note the need to use process.exit(0).

---

I haven't had time to check whether this should be an error to be reported in Bun or handled directly in MySQL2.

However, in the short research I've done, this seems to be related to the way Bun handles callbacks.

[Tanavya]

Is this related to my issue? oven-sh/bun#12155

[wellwelwel]

Related:

• ci(bun): fixes the process exit in Bun Canary tests #2387

[wellwelwel]

Unfortunately, I can't see which version of Bun started this, but this error was introduced later (before some specific version, it worked normally).

Looking at what has changed in this version could help clarify what happened (some Bun release around 24/01/18).

[steelywing]

I found the cause is if socket is FIN from the other side, the Socket will not exit.

I have a question from this code, is it better call stream.end() even if it is client:

node-mysql2/lib/connection.js

Line 894 in ac76a5d

end(callback) {

[wellwelwel]

@steelywing, it seems that Bun has fixed this bug in oven-sh/bun#13212.

After they release it, I'll revisit MySQL2 tests 🚀