fix(net/tls) we need to call end when we got FIN if allowHalfOpen is false

[cirospaciari]

What does this PR do?

Fix: #13184
Fix: #11414

• Documentation or TypeScript types (it's okay to leave the rest blank in this case)
• Code changes

How did you verify your code works?

Added a test

[robobun]

❌ @Jarred-Sumner, your commit 289f5a6 has 10 failures in #1737:

test/js/bun/http/serve.test.ts - 1 failing on 🍎 14 x64

test/cli/watch/watch.test.ts - timeout on 🪟 x64-baseline

test/cli/watch/watch.test.ts - timeout on 🪟 x64

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64

test/js/bun/jsc/bun-jsc.test.ts - timeout on 🪟 x64

test/cli/hot/hot.test.ts - 3 failing on 🪟 x64-baseline

test/cli/hot/hot.test.ts - 3 failing on 🪟 x64

test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64-baseline

test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64

test/js/node/tls/node-tls-server.test.ts - 1 failing on 🐧 22.04 aarch64

test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🪟 x64-baseline

test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 2 failing on 🪟 x64-baseline

test/js/node/fs/fs-promises-writeFile-async-iterator.test.ts - 2 failing on 🪟 x64

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64

test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64

[wellwelwel]

Hi @cirospaciari, thanks for this fix 🤝

I have this simple helper:

import { createConnection } from 'net';

const checkPort = (port: number, host: string): Promise<boolean> =>
  new Promise((resolve) => {
    const client = createConnection(port, host);

    client.on('connect', () => {
      client.destroy(); // it worked normally before this PR
      resolve(true);
    });

    client.on('error', () => {
      resolve(false);
    });
  });

---

After this PR, the process doesn't finish after a successful port check when using .destroy().

• If I change it to client.end() instead of client.destroy(), the behavior works as expected.

I also checked the regression changes, but they don't seem to "visit" the destroy method.

---

Do you think it would be interesting to open an issue for this? 🙋🏻‍♂️

Note

For some reason, this behavior only occurs in GitHub Actions environment.

• GitHub Actions:
  • ubuntu-latest
• Bun:
  • 1.1.23+4304368fc
  • 1.1.24+85a329911
  • 1.1.25-canary.36+d55b5cc16

[cirospaciari]

import { createConnection } from 'net';

const checkPort = (port: number, host: string): Promise<boolean> =>
  new Promise((resolve) => {
    const client = createConnection(port, host);

    client.on('connect', () => {
      client.destroy(); // it worked normally before this PR
      resolve(true);
    });

    client.on('error', () => {
      resolve(false);
    });
  });

Thanks for reporting and giving the reproduction, I just opened a PR with a fix for that.