Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlMessage to QueryError interface #1372

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mxw
Copy link

@mxw mxw commented Aug 6, 2021

it should be there; it's usually set. also delete redundant comments of the form /** the variable name, but with spaces */.

it should be there; it's usually set. also delete redundant comments of the form `/** the variable name, but with spaces */`.
@sidorares
Copy link
Owner

thanks @mxw .
I'm not an expert in TS typings, would it be possible to somehow validate typings from unit tests? Currently if we accidentally break something it's not visible until somebody using this module with TS starts to complain

@mxw
Copy link
Author

mxw commented Aug 7, 2021

i'm just barely aware that unit tests for typings exist, because i happened upon this today: https://github.com/discordjs/discord.js/blob/main/typings/tests.ts

but i'm not familiar with how they work or best practices; i'm a regular TS user but don't maintain any TS libraries myself.

@sidorares
Copy link
Owner

I guess just running TS compiler against some codebase that uses typings would be a test

@atlc
Copy link
Contributor

atlc commented Dec 12, 2023

+1 I would love to get this implemented instead of having to setup global overrides just to polyfill that property back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants