Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minVersion for ssl option. #1517

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Add minVersion for ssl option. #1517

merged 1 commit into from
Feb 16, 2022

Conversation

cweijan
Copy link
Contributor

@cweijan cweijan commented Feb 16, 2022

I need to configure minVersion option, there is currently no option for this, I can only configure it via as SslOptions as any in typescript, it's bad. so I created it.

@cweijan
Copy link
Contributor Author

cweijan commented Feb 16, 2022

I think a better way is by referencing SecureContextOptions in the type definition file, because ca also supports buffer, but currently only supports string.

@sidorares sidorares merged commit 943b8b2 into sidorares:master Feb 16, 2022
@sidorares
Copy link
Owner

Thanks @cweijan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants