chore(master): release 3.5.1

[github-actions]

🤖 I have created a release beep boop

3.5.1 (2023-07-10)

Bug Fixes

• improvements to allow to use Bun and tls (#2119) (fd44a2a)
• missing ResultSetHeader[] to query and execute (f649486)

---

This PR was generated with Release Please. See documentation.

[wellwelwel]

@sidorares, even using the prefix docs:, the release-please doesn't include it to changelog 😕

I tried to learn the release-please documentation, but found nothing related.

The only reference I could find about it was in a file from semver:
https://github.com/npm/node-semver/blob/main/release-please-config.json

[sidorares]

@sidorares, even using the prefix docs:, the release-please doesn't include it to changelog 😕

🤷 not sure how to help, we can ignore this issue for now and fix if/when we know a good solution

[wellwelwel]

No problem, because the changedRows change, I will wait for a conclusion before to merge it 🙋🏻‍♂️

[sidorares]

sure. I'll think a bit more and come back to you tomorrow. I feel this feature might be not reliable and misleading and maybe should be marked as potentially deprecated in the future

[wellwelwel]

sure. I'll think a bit more and come back to you tomorrow. I feel this feature might be not reliable and misleading and maybe should be marked as potentially deprecated in the future

Alright 🙋🏻‍♂️

---

For now 🚀

[sidorares]

@wellwelwel is there a way to deprecate a field in TS? Quick googling gives me jsdock comment option "@deprecated reason description" - is this the best option?

Reasons I want to remove completely changedRows:

• it's confusing given affectedRows exist
• not part of the protocol and is extracted from human readable message. Will break if wording is changed or server is localised or non-mysql server ( MariaDB etc ) choses to use different message.

Re 0 vs undefined when message can't be parsed - probably not that important right now

[wellwelwel]

Yes, I also suggested that this be done in the OkPacket types of query and execute.
We can also add a message explaining the reason for this.

A simple example:

node-mysql2/typings/mysql/lib/constants/Charsets.d.ts

Lines 225 to 226 in fd44a2a

	/** @deprecated */
	UTF8_GENERAL50_CI: number;

[wellwelwel]

If you think it's a good idea, we can do it before to release this version.

[sidorares]

If you think it's a good idea, we can do it before to release this version.

yes, let's do as part of this release in a small new PR

[wellwelwel]

I soon do that, just finishing a task 🙋🏻‍♂️

In changedRows, do you have a preference about how to report this in addition to "deprecated"?

Otherwise, I can resume it from:

• it's confusing given affectedRows exist
• not part of the protocol and is extracted from human readable message. Will break if wording is changed or server is localised or non-mysql server ( MariaDB etc ) choses to use different message.

[sidorares]

"changedRows is deprecated and might be removed in the future major release. Please use affectedRows property instead"

[github-actions]

🤖 Release is at https://github.com/sidorares/node-mysql2/releases/tag/v3.5.1 🌻