Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added close connections in quickstart. #2725

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

247software-sanket-gandhi
Copy link

@247software-sanket-gandhi 247software-sanket-gandhi commented Jun 3, 2024

Close connections were missing so I have added it in quickstart.

Fix: #2543

Close connections were missing so I have added it in quickstart.
@wellwelwel
Copy link
Sponsor Collaborator

wellwelwel commented Jun 3, 2024

Thanks, @sanketgandhi876 🙋🏻‍♂️

For the "Using Prepared Statements" (promise-based) example, I think it's better to set the connection before the try-catch to avoid the connection is not defined:

  connection.end()
  ^

ReferenceError: connection is not defined
    at file:///***/test.mjs:22:3
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@wellwelwel wellwelwel linked an issue Jun 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (9ac9f77) to head (eecc45e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2725   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          71       71           
  Lines       15731    15731           
  Branches     1344     1344           
=======================================
  Hits        14210    14210           
  Misses       1521     1521           
Flag Coverage Δ
compression-0 90.33% <ø> (ø)
compression-1 90.33% <ø> (ø)
tls-0 89.85% <ø> (ø)
tls-1 90.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@247software-sanket-gandhi
Copy link
Author

Yup, done!

@wellwelwel
Copy link
Sponsor Collaborator

wellwelwel commented Jun 3, 2024

@sanketgandhi876, to fix the lint errors, you can run cd website && npm run lint (or lintcheck to see what's wrong) 🧙🏻

@wellwelwel wellwelwel linked an issue Jun 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do you close connections???? Add connection.end() call to quickstart documentation
2 participants