Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pattern and selector to PromisePoolCluster#getConnection #3017

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Add pattern and selector to PromisePoolCluster#getConnection #3017

merged 1 commit into from
Sep 9, 2024

Commits on Sep 5, 2024

  1. Add pattern and selector to PromisePoolCluster#getConnection 

    The implementation of `PromisePoolCluster#getConnection` does not match the capabilities of `PoolCluster#getConnection` nor the definition in `promise.d.ts`.

This change corrects this by adding the missing `pattern` and `selector` parameters which are passed through to the underlying method.

Fixes sidorares#1381 

Note: I may have missed them, but I didn't see any tests for PromisePoolCluster to update or add to with this change.
    @TuckerWhitehouse
    TuckerWhitehouse authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0007f0c View commit details
    Browse the repository at this point in the history